Re: [libvirt] [PATCH] Rename iolimit to blockio.

After discussion with DB we decided to rename the new iolimit element as it creates the impression it would be there to limit (i.e. throttle) I/O instead of specifying immutable characteristics of a block device. This is also backed by the fact that the term I/O Limits has vanished from newer storage admin documentation. Signed-off-by: Viktor Mihajlovski <mihajlov(a)linux.vnet.ibm.com&gt; --- docs/formatdomain.html.in | 6 ++-- docs/schemas/domaincommon.rng | 6 ++-- src/conf/domain_conf.c | 30 +++++++++--------- src/conf/domain_conf.h | 2 +- src/qemu/qemu_capabilities.c | 4 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 10 +++--- tests/qemuhelptest.c | 8 ++-- .../qemuxml2argv-disk-blockio.args | 9 +++++ .../qemuxml2argvdata/qemuxml2argv-disk-blockio.xml | 33 ++++++++++++++++++++ .../qemuxml2argv-disk-iolimits.args | 9 ----- .../qemuxml2argv-disk-iolimits.xml | 33 -------------------- tests/qemuxml2argvtest.c | 4 +- 13 files changed, 78 insertions(+), 78 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-blockio.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-blockio.xml delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-iolimits.args delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-iolimits.xml

+++ b/src/qemu/qemu_capabilities.c @@ -172,7 +172,7 @@ VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST, "bridge", /* 100 */ "lsi", "virtio-scsi-pci", - "iolimits", + "blockio", "disable-s3",