Re: [libvirt] [PATCH 1/4] qemu: delete methods which are no longer supported
On Wed, Jun 26, 2019 at 04:54:40PM +0100, Daniel P. Berrangé wrote:
The public API entry points will report VIR_ERR_NO_SUPPORT to the
caller when a driver does not provide an implementation of a particular
method.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
src/qemu/qemu_driver.c | 31 -------------------------------
1 file changed, 31 deletions(-)
This is a followup to
commit 215d9393bb60615f957f456fec646cf187fec26e
qemu: driver: Drop support for qemu-attach
which also introduced an exception for domainQemuAttach in src/check-aclrules.pl:
diff --git a/src/check-aclrules.pl b/src/check-aclrules.pl
index be618f6c9f..23872cda98 100755
--- a/src/check-aclrules.pl
+++ b/src/check-aclrules.pl
@@ -61,7 +61,6 @@ my %whitelist = (
"interfaceClose" => 1,
"connectURIProbe" => 1,
"localOnly" => 1,
- "domainQemuAttach" => 1,
);
# XXX this vzDomainMigrateConfirm3Params looks
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)