[PATCH 1/2] Revert "docs: Add warning about using a cleared image with VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES_ZEROES"

From: Peter Krempa <pkrempa(a)redhat.com&gt; QEMU clears the images even when sparse mode is required so asking the users to do so is not needed. Remove the docs. This reverts commit 332ee4931a84ec23e7f6fcb963083318c1307dc7 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; --- docs/manpages/virsh.rst | 4 +--- include/libvirt/libvirt-domain.h | 5 +---- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 895a905b08..9b571761b8 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -3642,9 +3642,7 @@ transfer via the comma separated ``disk-list`` argument. The *--migrate-disks-detect-zeroes* option which takes a comma separated list of disk target names enables zeroed block detection for the listed migrated disks. These blocks are not transferred or allocated on destination, effectively -sparsifying the disk at the cost of CPU overhead. Users must ensure that any -pre-created storage source is cleared and thus reads all-zeroes before using -this option as otherwise the destination image may become corrupted. +sparsifying the disk at the cost of CPU overhead. With *--copy-storage-synchronous-writes* flag used the disk data migration will synchronously handle guest disk writes to both the original source and the destination to ensure that the disk migration converges at the price of possibly diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index ac5daf7d0c..1af5045571 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1276,10 +1276,7 @@ typedef enum { * * virDomainMigrate* params multiple field: The multiple values that list * the block devices for which zero detection (to avoid transferring zero blocks) - * is to be enabled. Users must ensure that any pre-created storage source on - * the destination will be cleared and thus read all-zeroes before using this - * feature, otherwise the destination image may become corrupted. - * This may increase CPU overhead of the migration. At the + * is to be enabled. This may increase CPU overhead of the migration. At the * moment this is only supported by the QEMU driver but not for the tunnelled * migration. * -- 2.49.0