Re: [libvirt] [PATCH] conf: storage: Remove iSCSI <auth> parsing

On Tue, Feb 23, 2010 at 11:39:56AM -0500, Dave Allan wrote: > On 02/23/2010 10:34 AM, Cole Robinson wrote: >> This was never wired up, and even generated broken XML until 0.7.2, >> so clearly no one was trying to use it. Dan recommended its removal, >> so lets drop it. > > CHAP auth is a fundamental part of iSCSI, so I don't think we should > remove support for it. I'm happy to fix it as soon as I get a bit of > time which will probably be in a couple of weeks. It isn't a difficult > thing to fix, I just have a bunch of stuff I need to get done before I > can work on it. That's being the case, I don't have a strong opinion on > whether we remove and re-add it, or just wait for me to fix it. One of the reasons I'd like us to at least modify it, is that we should not be including the password in the XML format. We should have it make use of the 'secrets' API for that, as we did for qcow encryption. So perhaps we should just aim to modify what we've got to use this Daniel