Re: [libvirt] [PATCH v2] Add new error code VIR_ERROR_AUTH_CANCELLED

On 01/27/2012 01:44 PM, Cole Robinson wrote: > And hook it up for policykit auth. This allows virt-manager to detect > that the user clicked the policykit 'cancel' button and not throw > an 'authentication failed' error message at the user. > > v2: > Don't leak pkout > > Signed-off-by: Cole Robinson <crobinso(a)redhat.com&gt; > --- > daemon/remote.c | 14 ++++++++++++-- > include/libvirt/virterror.h | 1 + > src/util/virterror.c | 6 ++++++ > 3 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/daemon/remote.c b/daemon/remote.c > index 1ada146..cedc26a 100644 > --- a/daemon/remote.c > +++ b/daemon/remote.c > @@ -2471,6 +2471,8 @@ remoteDispatchAuthPolkit(virNetServerPtr server ATTRIBUTE_UNUSED, > const char *action; > int status = -1; > char *ident = NULL; > + int authdismissed = 0; bool authdismissed = false; ACK with that nit fixed.