Re: [libvirt] [PATCHv2 8/8] Add test for virISCSIScanTargets
On 03/21/2014 08:04 AM, Roman Bogorodskiy wrote:
This breaks the build without iscsi backend:
gmake[3]: Entering directory `/usr/home/novel/code/libvirt/src'
CC util/libvirt_util_la-viriscsi.lo
util/viriscsi.c:83:46: error: use of undeclared identifier 'ISCSIADM'
virCommandPtr cmd = virCommandNewArgList(ISCSIADM, "--mode",
"session", NULL);
^
util/viriscsi.c:119:46: error: use of undeclared identifier 'ISCSIADM'
virCommandPtr cmd = virCommandNewArgList(ISCSIADM,
and other similar errors because of ISCSIADM is not defined.
I've pushed a fix that always defines ISCSIADM:
https://www.redhat.com/archives/libvir-list/2014-March/msg01353.html
Should these files go into STORAGE_DRIVER_ISCSI_SOURCES or
UTIL_SOURCES needs to be
adjusted depending if we want iscsi backend or not?
I think it's useful to test them even without the iscsi storage backend.
Jan
Attachments:
- signature.asc (application/pgp-signature — 836 bytes)