Re: [libvirt] [PATCH 2/3] Return bool in virBitmapGetBit

On Fri, Mar 06, 2015 at 01:01:13PM -0700, Eric Blake wrote: From the 23 callers in this patch: 10 explicitly ignore_value 5 are in a for loop from 0 to virBitmapSize (virProcessSetAffinity, nodeCapsInitNUMA, virDomainSnapshotAlignDisks, libxlDomainGetVcpuPinInfo) 1 checks the range before calling GetBit (virPortAllocatorSetUsed) 1 loops against the bitmap range (virPortAllocatorAcquired) I think these don't need any bounds-checking 2 of them take an enum as an argument (*CapsGet), I don't think we need a special case for QEMU_CAPS_LAST either. qemuBuildMemoryBackendStr admits to asking for out-of-range bits, so it would require checking the bounds up front, or a default of 'false'. In the rest of the callers, out-of-bounds queries are programming bugs, but since the origins of their indexes are not so straightforward, perhaps those should keep using the range-checking version. So there's only one caller where a default of 'false' makes sense. I think a function named virBitmapIsBitSet could return false on out-of-range (how can it be set if it's not in the bitmap?) In the meantime I've pushed the other two acked patches. Jan