Re: [libvirt] [PATCH] virkeyfile: fix compilation error with clang

> On 10 Dec 2019, at 15:11, Pavel Hrdina <phrdina(a)redhat.com&gt; wrote: > > Clang complains about condition being always true: > > src/util/virkeyfile.c:113:23: error: result of comparison of constant 128 with expression of type 'const char' is always true [-Werror,-Wtautological-constant-out-of-range-compare] > while (!IS_EOF && IS_ASCII(CUR) && CUR != ']') > ^~~~~~~~~~~~~ > src/util/virkeyfile.c:80:26: note: expanded from macro 'IS_ASCII' > ~~~ ^ ~~~ > > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > src/util/virkeyfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/virkeyfile.c b/src/util/virkeyfile.c > index 816bfae96d..ee29bd7aa6 100644 > --- a/src/util/virkeyfile.c > +++ b/src/util/virkeyfile.c > @@ -77,7 +77,7 @@ struct _virKeyFileParserCtxt { > #define IS_EOF (ctxt->cur >= ctxt->end) > #define IS_EOL(c) (((c) == '\n') || ((c) == '\r')) > #define IS_BLANK(c) (((c) == ' ') || ((c) == '\t')) > -#define IS_ASCII(c) ((c) < 128) > +#define IS_ASCII(c) (((unsigned char) c) < 128) Probably want parentheses around c.

> #define CUR (*ctxt->cur) > #define NEXT if (!IS_EOF) ctxt->cur++; > > -- > 2.23.0 > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list