Re: [PATCH] virsh-network: Don't check for virshXXXTypeFromString() >= VIR_XXX_LAST

They way our VIR_ENUM_IMPL() and virXXXTypeFromString() work is that for any string that's not recognized a negative one is returned. And, since VIR_XXX_LAST is passed to VIR_ENUM_IMPL() we can be sure that all enum members are covered. Therefore, there is no way that virXXXTypeFromString() can return a value that's bigger or equal to VIR_XXX_LAST. I've noticed two places where such comparison was made, both in cmdNetworkUpdate(). Drop them. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- tools/virsh-network.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)