2016-09-14 23:00 GMT+02:00 John Ferlan <jferlan@redhat.com>:
>
>
> On 08/09/2016 08:39 AM, Jason Miesionczek wrote:
>> ---
>>  src/hyperv/hyperv_wmi_generator.input | 485 ++++++++++++++++++++++++++++++++++
>>  1 file changed, 485 insertions(+)
>>
>
> I figure I can give at least "some" feedback. There's not a lot of
> hyperv experience on the team so whether what's done is technically
> correct w/r/t hyperv is the "unknown".  I also ran the series through
> Coverity which found some issues which I can work to point out.
>
>
> My 'git am *.eml' reports:
>
> Applying: hyperv: additional server 2008 wmi classes
> .git/rebase-apply/patch:15: space before tab in indent.
>         uint32   AccessMask
> .git/rebase-apply/patch:16: space before tab in indent.
>         boolean  Archive
> .git/rebase-apply/patch:17: space before tab in indent.
>         string   Caption
> .git/rebase-apply/patch:18: space before tab in indent.
>         boolean  Compressed
> .git/rebase-apply/patch:19: space before tab in indent.
>         string   CompressionMethod
> warning: squelched 412 whitespace errors
> warning: 417 lines add whitespace errors.
> Applying: hyperv: add cim types support to code generator
>
>
> Although I see Matthias has ACK'd this - before it's pushed, the spacing
> needs to be fixed. Follow existing format of 4 spaces rather than what
> appears to be 2 spaces and a <tab>
>
> As for the "details" of each structure, I'll defer to other reviewers
> and specifically Matthias' ACK
>
> You should do the clean up and post a v2 once I've gone through these.

No need for a v2 here. I've this fixed locally already.

I really need to get this review. Sorry for the delay.

--
Matthias Bolte
http://photron.blogspot.com

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list