Daniel Veillard wrote:
On Fri, Jan 08, 2010 at 09:05:25AM +0100, Jim Meyering wrote:
Per this thread:
http://thread.gmane.org/gmane.comp.emulators.libvirt/19672
here's a patch that solves both problems:
From 1b330b3070f904dfc1c380151afa3aaf2a121cd3 Mon Sep 17 00:00:00 2001 From: Jim Meyering <jim@meyering.net> Date: Thu, 7 Jan 2010 21:07:42 +0100 Subject: [PATCH] let "configure --disable-shared" work once again
Without this change, ./autogen.sh --disable-shared && make would evoke a "can not build a shared library" failure for libvirtmod.la. However, without the -shared link option in python/Makefile.am, it was possible to install non-functional python support. Instead, make --disable-shared also disable building python.
* configure.ac: Make --disable-shared imply --without-python and
configure.in actually
silently override --with-python.
Looks fine
* python/Makefile.am (libvirtmod_la_LDFLAGS): Do not use -shared. This reverts 8838ee39ab1c2bb7fffe93bfda220692664e8be6.
I still don't understand why this need to be reverted. With the configure.in change, then ./autogen.sh --disable-shared && make should not try to build the python shared lib
Using -shared in python/ would now be a little misleading, since it's useful only when building with --disable-shared, and python/ is no longer built with --disable-shared. Technically, it need not be reverted, but reverting it is fine, and imho, slightly better, since using -shared there merely encodes the current limitation that statically-linked python libraries are useless. We've already done that via configure, so if ever it's relaxed, there's only one place to modify.