On 1/15/20 1:37 PM, Christian Ehrhardt wrote:
If virHostdevManagerGetDefault in qemuhotplugtest fails it works for quite a while to later segfault when accessing mgr->activePCIHostdevs.
Report the error details and break on a failed init to see the real issue right away.
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> --- tests/qemuhotplugtest.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index a60c8d1c93..94440791d5 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -634,6 +634,11 @@ mymain(void) return EXIT_FAILURE;
driver.hostdevMgr = virHostdevManagerGetDefault(); + if (driver.hostdevMgr == NULL) { + VIR_TEST_VERBOSE("Could not initialize HostdevManager - %s\n", + virGetLastErrorMessage());
Suggestion/nit: make 'virGetLastErrorMessage()' with the same identation of the string above it:
+ VIR_TEST_VERBOSE("Could not initialize HostdevManager - %s\n", + virGetLastErrorMessage());
LGTM regardless, so Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
+ return EXIT_FAILURE; + }
#define DO_TEST(file, ACTION, dev, fial, kep, ...) \