14 Jun
2011
14 Jun
'11
3:16 p.m.
On 06/14/2011 04:49 AM, Daniel P. Berrange wrote:
On Thu, Jun 09, 2011 at 12:10:08PM -0500, Adam Litke wrote:
+ if (flags != 0) { + virLibDomainError(VIR_ERR_INVALID_ARG, + _("flags must be zero")); + goto error; + }
We don't want to check 'flags' in this place, because you could be a client app talking to a libvirt daemon which *does* support some flag values. Instead just have a 'virCheckFlags(0, -1)' in the QEMU driver impls. Same comment applies to all the other APIs in this patch
Yep, makes sense and changed in the next version. -- Adam Litke IBM Linux Technology Center