Re: [libvirt] [PATCH 2/8] virDomainBlockPull: Implement the main entry points

On Thu, Jun 09, 2011 at 12:10:08PM -0500, Adam Litke wrote: > + if (flags != 0) { > + virLibDomainError(VIR_ERR_INVALID_ARG, > + _("flags must be zero")); > + goto error; > + } We don't want to check 'flags' in this place, because you could be a client app talking to a libvirt daemon which *does* support some flag values. Instead just have a 'virCheckFlags(0, -1)' in the QEMU driver impls. Same comment applies to all the other APIs in this patch