On Fri, Mar 02, 2018 at 13:32:19 +0100, Viktor Mihajlovski wrote:
On 02.03.2018 12:33, Peter Krempa wrote: [...]
@@ -2028,8 +2029,12 @@ qemuMonitorGetCPUInfo(qemuMonitorPtr mon, (qemuMonitorJSONGetHotpluggableCPUs(mon, &hotplugcpus, &nhotplugcpus)) < 0) goto cleanup;
+ fast = virQEMUCapsGet(QEMU_DOMAIN_PRIVATE(mon->vm)->qemuCaps,
Don't do this. You'll need to determine it sooner. The main reason being that once you are in the monitor code, 'vm' is unlocked and should not be accesssed. Also we don't access the VM object trhough the mon object usually. OK. I've been struggling over this part since the availability of query-cpus-fast is tied to the QEMU instance and I didn't want to duplicate the capability in the qemuMonitor struct. Looks like I have to ...
You can pass it from the caller as we do in more than one place.