Re: [libvirt] [PATCH] Fix a qemuDomainPCIAddressSetFree memory leak
On 04/28/2010 05:08 PM, Eric Blake wrote:
On 04/28/2010 02:27 PM, Chris Lalancette wrote:
> qemuDomainPCIAddressSetFree was freeing up the hash
> table for the pci addresses, but not freeing up the addr
> structure. Looking over the callers of this function, it
> seems like they expect it to also free up the structure,
> so do that here.
>
> Signed-off-by: Chris Lalancette <clalance(a)redhat.com>
> ---
> src/qemu/qemu_conf.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index ed24916..5fa8c0a 100644
> --- a/src/qemu/qemu_conf.c
> +++ b/src/qemu/qemu_conf.c
> @@ -2110,7 +2110,7 @@ void qemuDomainPCIAddressSetFree(qemuDomainPCIAddressSetPtr
addrs)
> return;
>
> virHashFree(addrs->used, qemuDomainPCIAddressSetFreeEntry);
> - addrs->used = NULL;
> + VIR_FREE(addrs);
ACK.
Thanks, pushed.
--
Chris Lalancette