Re: [libvirt] [PATCHv2] qemu_hotplug: Don't free the PCI device structure after hot-unplug

On 05/22/2012 03:00 AM, Peter Krempa wrote: > The pciDevice structure corresponding to the device being hot-unplugged > was freed after it was "stolen" from activeList. The pointer was still > used for eg-inactive list. This patch removes the free of the structure > and frees it only if reset fails on the device. > --- > I've added a check for activePci to be non-null. This should not happen > now that the activePciHostdevs list does not get corrupted, but if the lookup for > some strange reason fails, don't enter pciResetDevice with NULL activePci that would > cause a segfault. > --- > > src/qemu/qemu_hotplug.c | 11 +++++++---- > 1 files changed, 7 insertions(+), 4 deletions(-) ACK.