Re: [libvirt] [PATCH] Fix usage of virFileMakePath, it doesn't set errno but returns it

On 07/05/2011 08:00 AM, Matthias Bolte wrote: s/explicity/explicit/ As long as we are already auditing all callers,... I'm half inclined to NACK this patch, and instead request that we fix virFileMakePath to be more like the bulk of our code: return 0 on success, -1 on error, and guarantee that errno is valid on error. Then we can simply write: if (virFileMakePath(configDir) < 0) { virReportSystemError(errno, ... without needing an extra 'err' variable. The biggest problem with this patch is that virFileMakePath still has no documentation. I guess I could be okay with the approach in this patch if it were to also include a comment just before virFileMakePath documenting that on error the return is a positive(!) errno value, if that means that fewer callers have to change, although I still feel that going with our normal conventions of a negative return on error would be a better cleanup. At any rate, until virFileMakePath is documented, we will continue to have problems with clients using it incorrectly. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org