Re: [libvirt] [PATCH] domaincapstest: Call virFileWrapperClearPrefixes only on non-WIN32
On Thu, 2019-04-11 at 12:33 +0100, Daniel P. Berrangé wrote:
On Wed, Apr 10, 2019 at 03:12:18PM +0200, Michal Privoznik wrote:
> The virFileWrapperClearPrefixes() function is defined only when
> building for non-WIN32.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
> ---
>
> Technically a build breaker fix, but I can't decide if ifdef is better
> or removing the call is better.
I don't much care since it only affects one place, but personally
I would have just make a no-op virFileWrapperClearPrefixes() impl
that is built on Win32.
We ended up using a different approach after all (947ea8665e4e).
Stubbing out ClearPrefixes() on win32 would only paper over the
issue; on the other hand, I'm pretty sure simply stubbing out all
virFileWrapper APIs would not fly because we *need* to wrap file
access for the tests using the API to work properly.
--
Andrea Bolognani / Red Hat / Virtualization