Re: [libvirt] [sandbox PATCH v2 03/19] Image: Add Hooking Mechanism

On Tue, Aug 04, 2015 at 08:11:09PM +0000, Eren Yagdiran wrote: Python comment syntax is '# ' What you have done here is declare a string. Also since the copyright line has accents in it, you need to add #coding=utf-8 as the 2nd line in the file, otherwise python refuses to load the code at all saying it doens't know the character encoding. THis should be the first line > + > +from abc import ABCMeta, abstractmethod > + > +class Source(): > + __metaclass__ = ABCMeta > + def __init__(self): > + pass > diff --git a/virt-sandbox-image/sources/__init__.py b/virt-sandbox-image/sources/__init__.py > new file mode 100644 > index 0000000..4830c7a > --- /dev/null > +++ b/virt-sandbox-image/sources/__init__.py > @@ -0,0 +1,29 @@ > +''' > +* > +* libvirt-sandbox-config-diskaccess.h: libvirt sandbox configuration > +* > +* Copyright (C) 2015 Universitat Politècnica de Catalunya. > +* > +* This library is free software; you can redistribute it and/or > +* modify it under the terms of the GNU Lesser General Public > +* License as published by the Free Software Foundation; either > +* version 2.1 of the License, or (at your option) any later version. > +* > +* This library is distributed in the hope that it will be useful, > +* but WITHOUT ANY WARRANTY; without even the implied warranty of > +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > +* Lesser General Public License for more details. > +* > +* You should have received a copy of the GNU Lesser General Public > +* License along with this library; if not, write to the Free Software > +* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > +* > +* Author: Eren Yagdiran <erenyagdiran(a)gmail.com&gt; > +* > +''' Same here about comment syntax, encoding and #!/usr being the first line. I don't think any of this stuff is needed, since we are directly importing the module we want based on its name This kind of change doesn't belong in the code. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|