On 02/12/14 20:46, Eric Blake wrote:
On 02/11/2014 09:26 AM, Peter Krempa wrote:
Add support for gluster backed images as sources for snapshots in the qemu driver. This will also simplify adding further network backed volumes as sources for snapshot in case qemu will support them. ---
Looks a bit confusing the number of variables we have to track as we swap between original and new, then fallback or commit. But I didn't spot anything obviously wrong in how you did it. I suspect that if we ever convert over to having domain XML track full backing chain semantics, we will have a lot to rewrite in this area of code to take advantage of that, but the future shouldn't hold up incremental progress in the present. ACK.
Tracking all the variables for a storage volume is really unpleasant. I'm planing on splitting out the source part for a storage volume (possibly including the backing chain) into a separate structure. This will allow then for easier copying and manipulation for all the tracked data. Unfortunately a change like that is really invasive. Peter