Re: [libvirt] [PATCH v2 06/14] qemuDomainAttachNetDevice: Move hostdev handling a bit further
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
The idea is to have function that does some checking at its
beginning and then have one big switch for all the interface
types it supports.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_hotplug.c | 26 ++++++++++++--------------
1 file changed, 12 insertions(+), 14 deletions(-)
Similar to patch 3, we'll now fail if filterref and queues exist in the
to be attached device's XML, but it doesn't check the backend tap. Not a
problem with this patch per se, but perhaps something that could be put
on the virtual todo list (make the checks consistent between building
command line and hotplug and of course do so by adding some helper
function rather than duplicating the checks which are prone to issues)...
ACK for what's here though
John