Re: [PATCH] virauth: Report error on empty auth result

On Mon, Mar 27, 2023 at 01:21:51PM +0200, Michal Privoznik wrote: No, not really, the whole docstring is: * When authentication requires one or more interactions, this callback * is invoked. For each interaction supplied, data must be gathered * from the user and filled in to the 'result' and 'resultlen' fields. * If an interaction cannot be filled, fill in NULL and 0. * * Returns 0 if all interactions were filled, or -1 upon error hence if interaction cannot be filled, then: .result = NULL; .resultlen = 0; and since interaction could not be filled, then the callback should not return 0 as that is the case only if all interactions were filled. However the fix is, I believe, actually correct. If we need some credentials and they were not provided (for example even the default one was not used -- that is also job of the callback) then we should still error out. We essentially do even before this patch, we just don't report an error. So I would scrap the rest of the commit and just say that we should also work with "buggy" auth callbacks. So with the commit message shortened: Reviewed-by: Martin Kletzander <mkletzan(a)redhat.com&gt;