Re: [Libvir] [PATCH] check the file name for --log
On Tue, Jul 31, 2007 at 08:12:56PM +0900, Atsushi SAKAI wrote:
Hi,
This patch fixes the trouble if execute virsh with
virsh --log --debug.
In this case FILE "--debug" is generated and
--debug is off.
Well it does what the user asked, is that really an error ?
Trying to guess what the user meant instead of executing what it asked for
is a good way to break other things. I'm not sure this should be done that
way.
This patch treat as error return
if it uses the hyphen "-" at the head of log file name.
If you really want to catch this then I will ask you to also update the
documentation for that option to explain that using a filename starting with
- is not accepted.
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/