Re: [PATCH 3/4] vircommand: Make sysconf(_SC_OPEN_MAX) failure non-fatal

On Tue, Aug 29, 2023 at 05:13:08PM +0200, Michal Privoznik wrote: > The point of calling sysconf(_SC_OPEN_MAX) is to allocate big > enough bitmap so that subsequent call to > virCommandMassCloseGetFDsDir() can just set the bit instead of > expanding memory (this code runs in a forked off child and thus > using async-signal-unsafe functions like malloc() is a bit > tricky). > > But on some systems the limit for opened FDs is virtually > non-existent (typically macOS Ventura started reporting EINVAL). > > But with both glibc and musl using malloc() after fork() is safe. > And with sufficiently new glib too, as it's using malloc() with > newer releases instead of their own allocator. > > Therefore, pick a sufficiently large value (glibc falls back to > 256, [1], so 1024 should be good enough) to fall back to and make > the error non-fatal. That's not suitable for macOS. THey have a constant OPEN_MAX we should be using that is way bigger than 1024.