Re: [libvirt] [PATCH 17/23] Replace use of VMX_ERROR with virReportError

On 07/18/2012 08:40 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; > > Update the VMX shared code to use virReportError instead of > the VMX_ERROR custom macro >

> @@ -3676,9 +3672,9 @@ virVMXFormatSerial(virVMXContext *ctx, virDomainChrDefPtr def, > break; > > default: > - VMX_ERROR(VIR_ERR_CONFIG_UNSUPPORTED, > - _("Unsupported character device TCP protocol '%s'"), > - virDomainChrTcpProtocolTypeToString( > + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, > + _("Unsupported character device TCP protocol '%s'"), > + virDomainChrTcpProtocolTypeToString( > def->source.data.tcp.protocol)); I'd probably indent the "def->source..." line differently so it's more visible that it is one level deeper.

One remark up there, but no biggie.