Re: [Libvir] [PATCH][RFC] libvirt ldoms support
Daniel Veillard wrote:
> diff --git a/configure.in b/configure.in
> --- a/configure.in
> +++ b/configure.in
> @@ -246,6 +246,10 @@ if test "$with_remote" = "yes" ; then
> LIBVIRT_FEATURES="$LIBVIRT_FEATURES -DWITH_REMOTE"
> fi
>
> +if test "$with_ldoms" = "yes" ; then
> + LIBVIRT_FEATURES="$LIBVIRT_FEATURES -DWITH_LDOMS"
> +fi
> +
I'm a bit surprized to not see the
AC_ARG_WITH(ldom, ....
option block in the configure.in, was that dropped from the patch ?
This was my fault. Our build system on Solaris is quite a bit different
due to automake issues, and I messed up porting it from one to the other.
I think this should be in a large part based on patform autodetection
and the --with-ldom/--without-ldom should only be used for code portability
tests and development.
I'll take a look at this before sending out another patch.
-Ryan