2010/4/5 Eric Blake <eblake@redhat.com>:
On 04/04/2010 11:36 AM, Matthias Bolte wrote:
It might be nice to list the regexp you used when grepping to find these instances. I tried git grep '\\n"' -- tools src, but that has a number of false positives to filter through. On the other hand, a more restrictive test may have let some offenders slip through.
I basically did that simple grep for \n" and eliminated false positives by hand.
+++ b/src/storage/storage_backend_disk.c @@ -455,7 +455,7 @@ virStorageBackendDiskPartBoundries(virStoragePoolObjPtr pool, unsigned long long cylinderSize = dev->geometry.heads * dev->geometry.sectors * SECTOR_SIZE;
- DEBUG("find free area: allocation %llu, cyl size %llu\n", allocation, cylinderSize); + DEBUG("find free area: allocation %llu, cyl size %llu", allocation, cylinderSize);
Fixing more than just \n here, but it's all whitespace fixes, so no need to split it out into a separate commit. :)
ACK.
Thanks, pushed. Matthias