Re: [libvirt] [jenkins-ci PATCH v3 06/12] guests: Install meson via pip

9 Oct 2019

      On Tue, 2019-10-08 at 22:48 +0200, Fabiano Fidêncio wrote:
...
+- name: '{{ project }}: Verify pip mappings'
+  fail:
+    msg: 'No mappings defined for {{ item }}'
+  with_items:
+    '{{ packages }}'
+  when:
+    - pip_mappings[item] is undefined
Turns out you actually need the

  mappings[item] is undefined

check here O:-) I'll add it back.
...
+- name: '{{ project }}: Flatten pip package list'
+  set_fact:
+    pip_flattened: '{{ pip_flattened }} + [ "{{ pip_temp[item] }}" ]'
+  with_items:
+    '{{ temp }}'
This should be

  with_items:
    '{{ pip_temp }}'

With these two issues addressed,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

I'll push patches 2-11 now.

-- 
Andrea Bolognani / Red Hat / Virtualization