Re: [libvirt] [PATCH] get rid of virBufferAsprintf where possible
On Tue, May 07, 2013 at 12:37:07PM +0200, Ján Tomko wrote:
Use virBufferAddLit or virBufferAddChar instead.
---
src/conf/domain_conf.c | 14 +++++++-------
src/conf/network_conf.c | 4 ++--
src/conf/storage_conf.c | 6 +++---
src/nwfilter/nwfilter_learnipaddr.c | 2 +-
src/phyp/phyp_driver.c | 28 +++++++++++++--------------
src/qemu/qemu_command.c | 38 ++++++++++++++++++-------------------
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_migration.c | 4 ++--
src/security/virt-aa-helper.c | 2 +-
src/util/virlog.c | 2 +-
src/vmx/vmx.c | 2 +-
tools/virsh-domain.c | 12 ++++++------
12 files changed, 58 insertions(+), 58 deletions(-)
In 25ae3d301508a6a9db7cdc5678ef5d93e793d9b8 Eric wrote a cfg.mk
check to prohibit use of virAsprintf with constant strings. Can
you extend this check to cover virBufferAsprintf too, so we do
not re-introduce these problems.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|