On 01/04/2011 09:33 AM, Daniel P. Berrange wrote:
Does this deserve a new <iobackend> element, or should it merely be a new optional attribute of the existing <driver> element, as in:
<driver name='qemu' type='qcow2' cache='none' iobackend='aiothreads'/>
I slightly prefer making it a new attribute of <driver>. The only reason I can see to make it a new <iobackend> element is if we think it will get significantly more complex in the future (necessitating new XML elements). Do we think that?
Yep, the whole '<driver>' element is really specifying an I/O backend, so I don't think it makes sense to add another <iobackend> element, nor is it particularly great as an attribute name. It should be an attribute on <driver> though
Any better ideas for an attribute name? The complaint was that Matthias' original proposal of naming the attribute 'aio' (as in <driver aio='threads'/>) felt a bit too specific to qemu's implementation; yet iobackend='aiothreads' is long. Maybe just io? <driver io='aiothreads'/> where io maps to qemu's ,aio=threads designation, but leaves us flexibility of adding other attribute values unrelated to the name aio? -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org