Re: [libvirt] [PATCH] virsh: don't call virSecretFree on NULL
On 03/29/2013 01:10 PM, Peter Krempa wrote:
On 03/29/13 13:04, Ján Tomko wrote:
> Since the refactoring in fbe2d49 we call virSecretFree even if
> virSecretDefineXML fails, which leads to overwriting the error
> message with:
> error: Invalid secret: virSecretFree
>
> Bug: https://bugzilla.redhat.com/show_bug.cgi?id=929045
> ---
> tools/virsh-secret.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Ah, shame on me. ACK and 1.0.4-worth.
Peter
Thanks, pushed now.