On Thu, Jan 24, 2013 at 10:17:16AM +0000, Daniel P. Berrange wrote:
On Thu, Jan 24, 2013 at 10:10:56AM +0000, Richard W.M. Jones wrote:
Version 3 of this patch. Because I now have to pass the 'mgr' pointer around, the patch is considerably more complicated than before.
Patch 1/2 is required so that I can use virReportSystemError when I don't need to have any optional arguments, ie. the equivalent of:
printf ("foo\n");
No, that's not allowed - everything must have a format string - even static messages - it should instead be:
printf ("%s", _("foo\n"));
make syntax-check ought to have complained about this IIRC.
I don't see why. Presumably the worry is that the translator will introduce a %-sequence into the string? That should be picked up by one of the msg* utilities. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW