On Wed, Sep 04, 2013 at 09:02:58AM -0600, Eric Blake wrote:
On 09/04/2013 08:53 AM, Daniel P. Berrange wrote:
On Wed, Sep 04, 2013 at 10:24:06AM -0400, Cole Robinson wrote:
Helps save space on the Fedora livecd, as requested here:
https://bugzilla.redhat.com/show_bug.cgi?id=977099 --- libvirt.spec.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
+%doc AUTHORS ChangeLog.gz NEWS README COPYING COPYING.LESSER TODO %doc docs/*.html docs/html docs/*.gif %doc docs/libvirt-api.xml %doc examples/hellolibvirt
The subject says you're moving the ChangeLog file, but you're in fact moving all docs files. I don't think it is right to move the COPYING and COPYING.LESSER files - I think those should say in libvirt-client so that they're always present for any possible libvirt sub-RPM install.
Oh, good point.
That means:
client: COPYING COPYING.LESSER daemon: none other[*]: AUTHORS ChangeLog.gz NEWS README TODO
where I have yet another question: should the other package be libvirt-docs or libvirt-devel? Your patch put them in devel, but I think docs might be a better fit.
Oh, I didn't realize we had a -docs package. I just looked at -devel and saw the website docs and didn't look further. It seems we're duplicating website in both -docs and -devel which is bad. We should remove those website docs from -devel and have all docs related stuff in -docs Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|