On Mon, May 04, 2020 at 02:09:02PM +0200, Andrea Bolognani wrote:
On Mon, 2020-05-04 at 09:48 +0000, Xuyandong (Yandong Xu) wrote:
+++ b/tools/virsh-domain.c @@ -5522,7 +5522,6 @@ static bool cmdDump(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; - bool ret = false; bool verbose = false; const char *name = NULL; const char *to = NULL; @@ -5556,12 +5555,12 @@ cmdDump(vshControl *ctl, const vshCmd *cmd)
virThreadJoin(&workerThread);
- if (!ret) + if (!data.ret) vshPrintExtra(ctl, _("\nDomain %s dumped to %s\n"), name, to);
cleanup: virshDomainFree(dom); - return !ret; + return !data.ret; }
This is in the same vein as fbc4e81a36d1, and I think we should definitely squeeze it in before release, so that's a
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
from me. Dan, what do you think?
Agreed, Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|