On 06/11/2016 01:43 PM, Jovanka Gulicoska wrote:
--- generator.py | 2 + libvirt-override-virConnect.py | 35 ++++++++++ libvirt-override.c | 153 +++++++++++++++++++++++++++++++++++++++++ sanitytest.py | 3 +- 4 files changed, 192 insertions(+), 1 deletion(-)
The code matches the network event API implementation, and I've tested it to verify it works. Only comment is a small one
diff --git a/sanitytest.py b/sanitytest.py index faabccb..3d4b28f 100644 --- a/sanitytest.py +++ b/sanitytest.py @@ -173,7 +173,8 @@ for cname in wantfunctions: continue if name[0:22] == "virConnectNetworkEvent" and name[-8:] == "Callback": continue - + if (name.startswith("virConnectStoragePoolEvent") and name.endswith("Callback")): + continue
# virEvent APIs go into main 'libvirt' namespace not any class if name[0:8] == "virEvent":
This bit removes a newline, please preserve the double newline spacing. Thanks, Cole