Re: [libvirt] [PATCH 5/6] Introduce alternate way to encode/decode arrays in DBus messages
On Thu, Mar 20, 2014 at 06:15:48PM +0100, Michal Privoznik wrote:
On 20.03.2014 13:28, Daniel P. Berrange wrote:
>Currently the DBus helper APIs require the values for an array
>to be passed inline in the variadic argument list. This change
>introduces support for passing arrays using a pointer to a plain
>C array of the basic type. This is of particular benefit for
>decoding messages when you don't know how many array elements
>are being received.
>
>Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
>---
> src/util/virdbus.c | 121 ++++++++++++++++++++++++++++++++++++++++++++++------
> tests/virdbustest.c | 93 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 201 insertions(+), 13 deletions(-)
Nice, we have a test too!
Mostly because I learnt the hard way that it is damn near impossible
to get this DBus code right without a test suite for it :-)
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|