25 Jul
2012
25 Jul
'12
4:47 a.m.
On 07/24/2012 11:40 PM, Eric Blake wrote:
On 07/24/2012 08:08 AM, Martin Kletzander wrote:
No check for conn->uri being NULL in virAuthGetConfigFilePath (valid state) made the client segfault. This happens for example with these settings: - no virtualbox driver installed (modifies conn->uri) - no default URI set (VIRSH_DEFAULT_CONNECT_URI="", LIBVIRT_DEFAULT_URI="", uri_default="") - auth_sock_rw="sasl" - virsh run as root
That are unfortunately the settings with fresh Fedora 17 installation with VDSM.
The check ought to be enough as conn->uri being NULL is valid in later code and is handled properly. --- v2: - copyright modified properly this time
ACK.
Thanks, pushed. Martin