Re: [libvirt] [libvirt-glib 1/4] Add GVirConfigDomainDiskDriver
On Thu, Jan 16, 2014 at 07:44:56PM +0000, Zeeshan Ali (Khattak) wrote:
> +
> +void gvir_config_domain_disk_driver_set_name(GVirConfigDomainDiskDriver *driver,
> + const char *name)
Since libvirt support only specific drivers and they are identified by
name, I'd suggest this be an enum.
We generally use enums in libvirt-gconfig when libvirt stores the value as
an enum. In this case it's stored as a string in domain_conf.c, and it's
defined as a string in domaincommon.rng, so it's better to stick with a
const char * in libvirt-glib too.
Christophe
Attachments:
- attachment.sig (application/pgp-signature — 181 bytes)