On Mon, Mar 14, 2016 at 10:19:18AM +0100, Peter Krempa wrote:
On Mon, Mar 14, 2016 at 09:47:05 +0100, Michal Privoznik wrote:
This function can be called over a domain definition that has no video configured. The tests/qemuxml2argvdata/qemuxml2argv-minimal.xml file could serve as an example. Problem is, before the check that domain has some or none video configured, def->videos is dereferenced causing a segmentation fault in case there's none video configured.
Caused by commit 95ca4fe2
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/qemu/qemu_command.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
ACK
Ah, thanks, I was hitting that while doing unrelated stuff :) Fwiw, Tested-by: Christophe Fergeau <cfergeau@redhat.com> Christophe