Re: [libvirt] [libvirt-glib 29/37] Add GVirConfigDeviceInput

11 Nov 2011


      just a comment about naming.

If we use prefix "Device" before devices class, I think it should be
done for the rest of the class for consistency.
...
+void gvir_config_device_input_set_bus(GVirConfigDeviceInput *input,
+                                      const char *bus)
+{
+    xmlNodePtr node;
+
+    node = gvir_config_object_get_xml_node(GVIR_CONFIG_OBJECT(input));
+    if (node == NULL)
+        return;
+    xmlNewProp(node, (xmlChar*)"bus", (xmlChar*)bus);
+}
The bus argument could be an enum too ("xen" (paravirtualized), "ps2" and "usb")

-- 
Marc-André Lureau