Re: [PATCH 1/9] rpc: split out helpers for TLS cert path location

On 6/7/24 16:26, Daniel P. Berrangé wrote: > We'll want to access these paths from outside the TLS context code, > so split them into a standalone file. > > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; > --- > src/rpc/meson.build | 6 +- > src/rpc/virnettlsconfig.c | 202 +++++++++++++++++++++++++++++++++++++ > src/rpc/virnettlsconfig.h | 68 +++++++++++++ > src/rpc/virnettlscontext.c | 70 ++----------- > 4 files changed, 285 insertions(+), 61 deletions(-) > create mode 100644 src/rpc/virnettlsconfig.c > create mode 100644 src/rpc/virnettlsconfig.h > > diff --git a/src/rpc/meson.build b/src/rpc/meson.build > index 9d98bc6259..d11d532d0f 100644 > --- a/src/rpc/meson.build > +++ b/src/rpc/meson.build > @@ -1,6 +1,10 @@ > gendispatch_prog = find_program('gendispatch.pl') > > -socket_sources = [ > +tlsconfig_sources = [ > + files('virnettlsconfig.c'), > +] I believe this should be either: tlsconfig_sources = [ ... ]

or tlsconfig_sources = files( ... ) and given that the latter remembers the subdir of passed files then I'd just stick to it.