On Wed, Feb 16, 2011 at 05:10:10PM -0700, Jim Fehlig wrote:
Jim Fehlig wrote:
Daniel Veillard wrote:
Thanks everybody for the testing feedback and fixes, in retrospect I should really had done this in previous releases ! So the third rc tarball is out, it's likely to be the last one before the release (within 48 hours):
ftp://libvirt.org/libvirt/libvirt-0.8.8-rc3.tar.gz
give it a try !
Building and passing minimal tests on all supported openSUSE/SLE distros, which in itself is a good exercise of the various configure options.
However, I'm trying to run libvirt-tck on openSUSE11.4rc1, qemu0.14rc1, and libvirt 0.8.8rc3 (lots of rc's :)) and getting quite a few failures. The failing qemu invocations look like:
2011-02-15 12:15:05.863: starting up LC_ALL=C PATH=/sbin:/usr/sbin:/usr/local/sbin:/root/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/X11R6/bin:/usr/games:/usr/lib64/jvm/jre/bin HOME=/root USER=root LOGNAME=root /usr/bin/qemu-kvm -S -M pc-0.14 -enable-kvm -m 64 -smp 1,sockets=1,cores=1,threads=1 -name tck -uuid 7767756e-9160-41d3-f7a5-0af2aed17d1b -nographic -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/tck.monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc -boot c -kernel /var/cache/libvirt-tck/os-i686-hvm/vmlinuz -initrd /var/cache/libvirt-tck/os-i686-hvm/initrd -drive file=/var/cache/libvirt-tck/os-i686-hvm/disk.img,if=none,id=drive-virtio-disk0,boot=on,format=raw -device virtio-blk-pci,bus=pci.0,addr=0x2,drive=drive-virtio-disk0,id=virtio-disk0 -chardev pty,id=charserial0 -device isa-serial,chardev=charserial0,id=serial0 -usb -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 char device redirected to /dev/pts/1 Two devices with same boot index 0
I think qemu0.14 is less tolerable of specifying 2 boot devices, in this case implicitly with -kernel and boot=on for the disk.
I'll try to look more later but for now need some sleep.
I see Bruce brought this up on qemu ml [1]. Seems removing boot=on when using linuxboot.bin is preferred solution. I'm attaching a hack that allows me to pass the libvirt-tck domain tests but would really like comment from someone familiar with code, particularly the bootindex stuff in qemu-kvm.
Thanks! Jim
[1] http://lists.nongnu.org/archive/html/qemu-devel/2011-02/msg01892.html
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 05f427c..9186707 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3112,7 +3112,7 @@ qemuBuildCommandLine(virConnectPtr conn, }
/* If QEMU supports -drive param instead of old -hda, -hdb, -cdrom .. */ - if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE) { + if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE && !def->os.kernel) { int bootCD = 0, bootFloppy = 0, bootDisk = 0;
/* If QEMU supports boot=on for -drive param... */
This patch prevents libvirt actually creating any disks at all. Your idea sounds good though. I think if you put the '&& !def->os.kernel' bit in the next conditional it will work, eg try /* If QEMU supports boot=on for -drive param... */ if ((qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE_BOOT) && !def->os.kernel) { Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|