Re: [libvirt] [dbus PATCH v2 5/6] virtDBusDomainDestroy: Use virDomainDestroyFlags instead of virDomainDestroy
On Fri, Mar 23, 2018 at 05:58:03PM +0100, Katerina Koukiou wrote:
We need to catch Exceptions when testing this API call, since
virDomainDestroyFlags
will be supported in test-driver in 4.2.0 libvirt release.
Better version checks for unsupported API calls need to be done in all tests,
but it's not relevant to this commit.
When virConnectGetVersion will be supported we can move to better implementation,
and python logging should be used to provide proper warnings for skipped tests.
Long lines in commit message, the unwritten rule (suggestion) is to
keep it under 72 characters per line.
Pavel
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)