Re: [libvirt] [RFC PATCH v1 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

On Thu, Aug 23, 2012 at 16:31:51 +0530, Harsh Prateek Bora wrote: > Qemu accepts gluster protocol as supported storage backend beside others. > This patch allows users to specify disks on gluster backends like this: > > <disk type='network' device='disk'> > <driver name='qemu' type='raw'/> > <source protocol='gluster' name='volume/image'> > <host name='example.org' port='6000' transport='socket'/> > </source> > <target dev='vda' bus='virtio'/> > </disk> > > Note: In the <host> element above, transport is an optional attribute. > Valid transport types for a network based disk can be socket, unix or rdma. > > TODO: > - Add support for IPv6 format based server addr > - Support for transport types other than socket. Overall, this patch set looks fine. See my comments inline.