Re: [libvirt] [PATCH] portability: fix virNetDevSetMAC and virNetDevExists on BSD
On 05/11/2013 09:05 AM, Roman Bogorodskiy wrote:
Eric, thanks for fixing these stupid errors of mine.
Do you run 'syntax-check' on your FreeBSD vm?
So far, I've just been running it on Fedora. I suspect that it makes
some GNU assumptions (at least maint.mk comes from gnulib, and upstream
gnulib has already stated that it's okay for maintainer-only tools to
assume "sane" systems, where "sane" excludes anything that requires
lots
of porting effort). That is, while I _know_ syntax-check won't work on
Solaris, I don't know whether the fact that it fails on BSD is
intentional, or something that can be easily fixed with minimal
maintenance nightmares.
It fails on libvirt_unmarked_diagnostics for me, like this:
maint.mk: found unmarked diagnostic(s)
gmake: *** [sc_libvirt_unmarked_diagnostics] Error 1
Full log here:
http://people.freebsd.org/~novel/misc/libvirt_syntax_check.txt
I'll take a look.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)