Re: [libvirt] [jenkins-ci PATCH 2/6] mingw*-libosinfo: Add mingw*-libsoup as dependency
On Wed, Jul 31, 2019 at 1:54 PM Andrea Bolognani <abologna(a)redhat.com> wrote:
On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote:
> It's been introduced as dependency as part of v1.6.0 release.
Is that so? Because the native build has had the dependency on
libsoup ever since
commit 1eab5a66eb0abd922a67e2c96a4c46efce525548
Author: Andrea Bolognani <abologna(a)redhat.com>
Date: Tue Oct 3 18:11:38 2017 +0200
ansible: Add libosinfo project
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
eg. the day it was introduced. So it seems to me we just messed
up when in
Old tests on libosinfo were relying on libsoup and that's the reason I
do believe the dependency was there.
Pino dropped the dependency a long time ago here:
```
commit b61be0405f678986ac344f414fa907af24670488
Author: Pino Toscano <ptoscano(a)redhat.com>
AuthorDate: Mon Aug 7 18:18:34 2017 +0200
Commit: Christophe Fergeau <cfergeau(a)redhat.com>
CommitDate: Mon Oct 16 11:12:22 2017 +0200
Switch from libsoup to libcurl
libsoup is used to check the validity of URLs in distributions in
osinfo-db; OTOH it supports only HTTP(S), so this limits the checks to
that protocol.
To overcome this limitation, switch to libcurl: while it requires
slightly more code to do the same task, it provides a bit more
flexibility, and support for other protocols. No version check is
performed, since the APIs used are old enough.
Adapt also the README, and the packaging files.
```
However, libvirt-jenkins-ci was never updated.
[snip]
Best Regards,
--
Fabiano Fidêncio