Re: [libvirt] [PATCH v2] virsh: Two new fields for command domblklist

On 01/12/2012 03:53 AM, Osier Yang wrote: > Disk "type" and "device" are generally interesting stuffs the s/stuffs/stuff/ > user who wants to known too. To not breaking the scripts which s/who wants to known too/may want to know, too/ s/breaking the/break any/ > parses the output field, new options "--details" is introduced s/parses/parsed/ s/new options/a new option/ > to output the two introduced fields. > --- > tools/virsh.c | 32 +++++++++++++++++++++++++++++--- > tools/virsh.pod | 19 ++++++++++--------- > 2 files changed, 39 insertions(+), 12 deletions(-) > > +++ b/tools/virsh.pod > @@ -512,15 +512,16 @@ to a unique target name (<target dev='name'/>) or source file (<source > file='name'/>) for one of the disk devices attached to I<domain> (see > also B<domblklist> for listing these names). > > -=item B<domblklist> I<domain> [I<--inactive>] > - > -Print a table showing the names of all block devices associated with > -I<domain>, as well as the path to the source of each device. If > -I<--inactive> is specified, query the block devices that will be used > -on the next boot, rather than those currently in use by a running > -domain. Other contexts that require a block device name (such as > -I<domblkinfo> or I<snapshot-create> for disk snapshots) will accept > -either target or unique source names printed by this command. > +=item B<domblklist> I<domain> [I<--inactive>] [I<--details>] > + > +Print a table showing the brief information of all block devices > +associated with I<domain>. If I<--inactive> is specified, query the > +block devices that will be used on the next boot, rather than those > +currently in use by a running domain. If I<--details> is specified, > +disk type and device value will be printed additionally. Other s/be printed additionally/also be printed/ > +contexts that require a block device name (such as I<domblkinfo> > +or I<snapshot-create> for disk snapshots) will accept either target > +or unique source names printed by this command. ACK with the grammar cleanups. And don't feel bad - English can be a tough language; you did quite well at getting the point across, even if I was able to provide some ideas to polish the final wording. :)