Re: [libvirt PATCH] meson: add -Wall and -Wextra explicitly for buildtype=plain

On 9/1/20 8:08 AM, Pavel Hrdina wrote: > If someone runs `meson setup --buildtype plain` meson ignores > warning_level=2 that is in our meson.build file. The implication is > that Meson will not automatically add -Wall which enables -Wformat. > > This breaks building libvirt from git with the buildtype set to plain. > > There is an issue reported [1] to not ignore warning_level silently > and the change to ignore it was done by upstream commit [2]. > > [1] <https://github.com/mesonbuild/meson/issues/7399> > [2] <https://github.com/mesonbuild/meson/commit/8ee1c9a07a3a35e3ed262fbc358fd8... > > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > meson.build | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) I'm just learning meson so not particularly confident to review patches, but will note this change causes a warning in downstream package build where the %meson rpm macro is used [ 23s] Compiler for C supports arguments -Wall: YES [ 23s] Compiler for C supports arguments -Wextra: YES [ 23s] meson.build:594: WARNING: Consider using the built-in warning_level option instead of using "-Wall". [ 23s] meson.build:594: WARNING: Consider using the built-in warning_level option instead of using "-Wextra".