[libvirt] [libvirt-php 2/3] Fixed some compilation warnings
Eliminated some compliation warings;
Fixed "differ in signedness" warnings, It may need to be reviewed.
* src/libvirt.c: Added header "standard/info.h"; Added return statement
for libvirt_virConnectAuthCallback(); Fixed "differ in signedness"
by change or casting those variables to unsigned.
---
src/libvirt.c | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 693443c..524bb6f 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -5,6 +5,7 @@
#include "php.h"
#include "php_ini.h"
#include "php_libvirt.h"
+#include "standard/info.h"
#include <libvirt/libvirt.h>
#include <libvirt/virterror.h>
@@ -480,6 +481,8 @@ static int libvirt_virConnectAuthCallback(virConnectCredentialPtr
cred, unsigne
}
//printf ("Result: %s (%i)\n",cred[i].result,cred[i].resultlen);
}
+
+ return 0;
}
static int libvirt_virConnectCredType[] = {
@@ -512,8 +515,8 @@ PHP_FUNCTION(libvirt_connect)
int array_count;
char *key;
- int key_len;
- long index;
+ unsigned int key_len;
+ unsigned long index;
unsigned long libVer;
unsigned long typeVer;
@@ -718,7 +721,7 @@ PHP_FUNCTION(libvirt_domain_lookup_by_uuid)
php_libvirt_connection *conn=NULL;
zval *zconn;
int uuid_len;
- char *uuid=NULL;
+ unsigned char *uuid=NULL;
virDomainPtr domain=NULL;
php_libvirt_domain *res_domain;
@@ -1145,7 +1148,7 @@ PHP_FUNCTION(libvirt_domain_get_uuid)
GET_DOMAIN_FROM_ARGS("r",&zdomain);
uuid=emalloc(VIR_UUID_BUFLEN);
- retval=virDomainGetUUID(domain->domain,uuid);
+ retval=virDomainGetUUID(domain->domain, (unsigned char *)uuid);
if (retval!=0) RETURN_FALSE;
RETURN_STRING(uuid,0);
--
1.7.1