On Fri, May 05, 2023 at 04:41:34PM +0200, Erik Skultety wrote:
So, I couldn't merge this just yet, as tests started failing on F38, here's an MR with necessary fixes for that: https://gitlab.com/libvirt/libvirt-tck/-/merge_requests/41
I don't feel qualified to review those changes, sorry!
Here's a pipeline including ^those fixes + Fedora 38 (as promised): https://gitlab.com/eskultety/libvirt/-/pipelines/858474139
Looking good.
@abologna: After the lcitool refresh I also need this bit in to fix Leap 15.4:
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3a36c0ef18..2378b1a39f 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -118,10 +118,10 @@ codestyle_prebuilt_env: - .codestyle_job - .gitlab_native_build_job_prebuilt_env needs: - - job: x86_64-opensuse-leap-154-container + - job: x86_64-opensuse-leap-15-container optional: true variables: - NAME: opensuse-leap-154 + NAME: opensuse-leap-15
codestyle_local_env: extends: @@ -129,7 +129,7 @@ codestyle_local_env: - .gitlab_native_build_job_local_env variables: IMAGE: registry.opensuse.org/opensuse/leap:15.4 - NAME: opensuse-leap-154 + NAME: opensuse-leap-15
Please let me know if your RB still stands or whether I need to respin with that change.
That should have happened as part of a3cc0e9ceb3e. Good catch. Please post it as a separate patch though. -- Andrea Bolognani / Red Hat / Virtualization